lightninglabs / lightninglabs/taproot-assets

build: add shellcheck stage to Makefile and CI pipeline

Open
#383 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
525
Forks
150
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Mentioned in #380 - I don't think any build issue has sprung from errors shellcheck has flagged, but this would still be helpful. Could also port changes to similar scripts in other projects like lnd and btcd.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the Makefile and CI pipeline, then compare the shellcheck setup with similar scripts in lnd and btcd. Done means shellcheck runs as a Makefile stage and in CI without introducing build failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system, ci-cd, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.