lightninglabs / lightninglabs/taproot-assets
Clarify asset name handling
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 525
- Forks
- 150
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
Recurring discussion mostly recently referenced here:
https://github.com/lightninglabs/taro-private/pull/30#discussion_r1186569668
IIUC, our implementation currently disallows using the empty string, "" , as an asset name. Which we also want to specify in the BIPs.
This propagates to changes like group anchor support, since "" is also the zero value for strings. So there is no need to use *string for asset names.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked taro-private pull request discussion, then trace asset-name handling and the group-anchor changes in this repository alongside the relevant BIPs. Done means the implementation and BIPs consistently specify that empty asset names are disallowed, with string rather than *string used where this change applies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, documentation
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100