lightninglabs / lightninglabs/taproot-assets

[feature]: don't use/block `HtlcInterceptor` when running in standalone mode

Open
#1,732 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement gRPC RFQ
Dominant language
Go
Stars
525
Forks
150
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Today (until https://github.com/lightningnetwork/lnd/issues/7162 is addressed), lnd's HtlcInterceptor only allows a single RPC client to be connected at any time.

tapd's OrderHandler "consumes" that single slot on startup, making it impossible for other user apps to use the HtlcInterceptor.

We should allow the RFQ functionality to be turned off if tapd isn't running as part of litd in integrated mode and Taproot Asset Channel functionality is not available anyway, so the HtlcInterceptor can be freed up.

Ideally, of course, this falls away if https://github.com/lightningnetwork/lnd/issues/7162 is addressed first.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the OrderHandler in rfq/order.go around line 773, then trace how tapd distinguishes standalone mode from integrated litd operation. Identify where RFQ functionality is initialized and define the standalone behavior so the HtlcInterceptor remains available to other clients. Verify that integrated mode and existing Taproot Asset Channel behavior are unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.