lightninglabs / lightninglabs/taproot-assets
[bug]: `NewAddr` should default to `ADDR_VERSION_V2` when `asset_id` is passed
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 525
- Forks
- 150
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
In https://github.com/lightninglabs/taproot-assets/pull/1587 when using [NewAddr](https://lightning.engineering/api-docs/api/taproot-assets/taproot-assets/new-addr/) we default to `ADDR_VERSION_V2` for `address_version` if `group_key` is passed. If `asset_id` is passed, we default to `ADDR_VERSION_V1`.
We need to debate the pros and cons of making `NewAddr` also default to `ADDR_VERSION_V2` when `asset_id` is passed. Should we do it at all, and if so, at what release in the future is the best time to change this default?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the NewAddr API documentation and pull request #1587 to compare the existing defaults for group_key and asset_id. Review the compatibility and release implications of changing the asset_id default, then document a decided default and target release as the completed outcome.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100