lightninglabs / lightninglabs/taproot-assets
[feature]: multi RFQ send: shard weighted average `taproot-assets.experimental.rfq.acceptpricedeviationppm`
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 525
- Forks
- 150
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
With https://github.com/lightninglabs/taproot-assets/pull/1613 we have the ability to split a payment across multiple shards to have a higher probability of payment success.
We don't have much control over the rate limits used used. Currently we only have taproot-assets.experimental.rfq.acceptpricedeviationppm to control if a rate is too high. This is a bit unflexible because we may only need a small shard to be sent through a high rate peer and the weighted average rate for all shards of the entire combined payment could be well under taproot-assets.experimental.rfq.acceptpricedeviationppm if most other outbound capacity is much lower than taproot-assets.experimental.rfq.acceptpricedeviationppm.
Would like to see some way to limit taproot-assets.experimental.rfq.acceptpricedeviationppm more intelligently based on the shard size actually used to send the payment.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading PR 1613 to understand multi-shard payment sending, then locate the handling of taproot-assets.experimental.rfq.acceptpricedeviationppm. Define how the rate limit should account for the shard sizes and weighted average across the combined payment; done means the behavior is specified and covered for multi-RFQ sends.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- payments
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100