lightninglabs / lightninglabs/taproot-assets

[feature]: automatically FinalizeBatch when running MintAsset by default

Open
#1,277 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement minting
Dominant language
Go
Stars
525
Forks
150
Avg merge
2d 15h
Merged PRs (30d)
31

Description

In order to simplify the on boarding of new users to the taproot assets protocol, we should automatically FinalizeBatch when running MintAsset by default (and have the option when running MintAsset to not automatically FinalizeBatch if we want to do it in two separate steps). New users likely just want to test minting an asset and will be confused of the purpose of the FinalizeBatch step. The FinalizeBatch step seems to be separate so that we can run MintAsset many times and then record all minted assets with a single on chain transaction. This is a very powerful function of the protocol, but it likely won't be used by new users, especially when they may only run MintAsset one or two times and on chain fees on main net may be low at the time, or they are running on testnet or regtest where there is no concern for fees.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the MintAsset and FinalizeBatch entry points in the Go daemon and trace how the two operations currently interact. Done means MintAsset finalizes by default while exposing an option to keep finalization as a separate step, with the behavior verified for both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.