lightninglabs / lightninglabs/taproot-assets
[feature]: Replace RPC endpoints `AddAssetSellOrder` and `AddAssetBuyOrder` with `InitRfq*`
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 525
- Forks
- 150
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
We need to update our RPC interface before the 0.4.2 release to ensure stability and prepare for asset-to-asset channel payments.
The current buy/sell terminology doesn't accurately represent asset-to-asset payments, where we divest and receive tap assets in the same event. Using buy/sell terminology also causes unnecessary complications for developers; the new endpoint should have fields that directly relate to the invoice payment process or the invoice settlement receive process.
Therefore, we should replace the AddAssetSellOrder and AddAssetBuyOrder endpoints with a new InitRfq* endpoint that initiates the RFQ process when called.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the RPC definitions and callers for AddAssetSellOrder and AddAssetBuyOrder, then review how the RFQ process is initiated and how invoice payment or settlement receive fields are represented. Done means replacing both endpoints with an InitRfq* endpoint whose fields match the intended asset-to-asset payment flow before the 0.4.2 release.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100