lightninglabs / lightninglabs/pool

account: allow a "deposit all" option

Open
#88 0 comments 3 reactions 0 assignees View on GitHub
accounts deposit enhancement
Dominant language
Go
Stars
259
Forks
51
PR merge metrics
No merged PRs in 30d

Description

In the past for lnd we had an issue where a user would try to send coins, but then needed to pay for fees, so they'd have to subtract an amount then try again, over and over again. We eventually add the `--sweepall` option in `SendCoins` to address this. We should add a similar flag for `pool accounts deposit` that lets the user deposit _all_ their coins (from the lnd wallet) into `poold`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the `pool accounts deposit` command and compare its behavior with lnd's `SendCoins --sweepall` option. Trace how the deposit amount is selected and verify that the completed behavior deposits all coins from the lnd wallet into poold while still handling fees.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.