lightninglabs / lightninglabs/pool
feature request: verify order specifications before asking for confirmation
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 259
- Forks
- 51
- PR merge metrics
- No merged PRs in 30d
Description
Copied over from a tester on the other repo:
If I
Enter an order for a non-144-multiple min_duration
Enter an order below 1 unit
I only get the error AFTER I confirm. I expect the order-submit command to reject my invalid order before asking me to confirm. Now it gives me the error after I type "yes"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the order-submit command and trace how min_duration and order quantity are validated relative to the confirmation prompt. Reproduce the non-144-multiple and below-1-unit cases; done means both invalid orders are rejected before confirmation is requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100