lightninglabs / lightninglabs/pool
[bug] account: don't change account status until the action has been successfully completed
@positiveblue is already working on this.
Since Jan 12, 2023.
- Dominant language
- Go
- Stars
- 259
- Forks
- 51
- PR merge metrics
- No merged PRs in 30d
Description
When we close an account we first [update its status and value in the clientdb](https://github.com/lightninglabs/pool/blob/master/account/manager.go#L1683) and then [try to broadcast the spending tx](https://github.com/lightninglabs/pool/blob/master/account/manager.go#L1696).
If we don't succeed publishing the tx our account will already be marked as `pending to close` so [we won't be able to retry it anymore](https://github.com/lightninglabs/pool/blob/master/account/manager.go#L1541).
**Expected behavior**
If attempting to close an account fails, the account is not left in a terminal state. You can continue using it normally or retry to close it
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.