lightninglabs / lightninglabs/pool
rpcserver: crash in case client fails to parse batch
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 259
- Forks
- 51
- PR merge metrics
- No merged PRs in 30d
Description
If the server sends a batch that the client is unable to parse (https://github.com/lightninglabs/pool/blob/073fe0d369e1e544e0752a1f804a5851fefb71bf/rpcserver.go#L362), we will crash when attempting to use the nil batch struct in the reject message: https://github.com/lightninglabs/pool/blob/073fe0d369e1e544e0752a1f804a5851fefb71bf/rpcserver.go#L1447
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in rpcserver.go at the batch handling around line 362 and the reject-message logic around line 1447. Trace the client-parse-failure path and verify that it no longer crashes when the batch is nil while producing the intended rejection response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100