lightninglabs / lightninglabs/pool
Deposit should require >0 sat (for amount and/or fee)
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 259
- Forks
- 51
- PR merge metrics
- No merged PRs in 30d
Description
I just ran pool a d --trader_key xxx --amt 0 --sat_per_vbyte 0 (mainly to check if my syntax is correct) and noticed that it didn't complain. Instead, the transaction went through:
{
"account": {
"trader_key": "xxx",
"outpoint": "xxx:1",
"value": 123,
"available_balance": 0,
"expiration_height": 123,
"state": "PENDING_UPDATE",
"latest_txid": "yyy"
},
"deposit_txid": "yyy"
}
Expected behavior
Some kind of error message.
Actual behavior
Transaction is sent (I assume).
System information
pool standalone: pool version 0.4.3-alpha commit=auctioneerrpc/v1.0.1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the pool a d --trader_key xxx --amt 0 --sat_per_vbyte 0 command and trace its amount and fee validation. Done means zero satoshis for either value is rejected with an error instead of sending a transaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100