lightninglabs / lightninglabs/lndmon
superfluous response.WriteHeader call from client_golang
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 160
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Description
Getting this error from lndmon repeatedly in our logs:
```
2021/03/26 09:06:14 http: superfluous response.WriteHeader call from github.com/prometheus/client_golang/prometheus/promhttp.(*responseWriterDelegator).WriteHeader (delegator.go:58)
```
Posts like these suggest it would be fixed by updating to a recent version of client_golang
https://github.com/prometheus/statsd_exporter/issues/257
https://github.com/prometheus/client_golang/issues/730
https://github.com/google/cadvisor/issues/2537
https://github.com/thanos-io/thanos/issues/1086
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking how lndmon records its client_golang dependency, then compare it with the recent versions referenced in the linked issues. Use the reported delegator.go warning as the failure to verify; done means the repeated superfluous response.WriteHeader message no longer appears in lndmon logs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, prometheus
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100