lightninglabs / lightninglabs/lightning-terminal
Unify the earn rates throughout the application
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 595
- Forks
- 135
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 10
Description
Is your feature request related to a problem? Please describe.
Currently the rates on pool are described in 3 different denominations:
- % APY
- Interest rate in bps
- Bid/Ask premium in sats
If I see a channel on the Sell Order Board on Pool Lite, I know what APY I need to match in order to fit that order.
However, I cannot go to pool and select that APY. Instead, I need to fiddle with the Ask premium in sats until It matches the APY (or I need to calculate it manually).
Describe the solution you'd like
Make all earn rates denominated in either % APY, or bps or sats. But not a mix of all 3.
Describe alternatives you've considered
Allow users to enter either % APY, or bps, or sats when creating a Bid/Ask order. Currently it is only allowing the enter the total premium in sats.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the rate displays on the Pool Lite Sell Order Board with the rate entry flow for Pool Bid/Ask orders. Decide which denomination or input options the feature will support, then verify that displayed and entered earn rates are consistent across those flows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- fintech-quant
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100