lightninglabs / lightninglabs/faraday
Payment requests should NOT be decoded via a network call
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Go
- Stars
- 130
- Forks
- 35
- Avg merge
- 7h 54m
- Merged PRs (30d)
- 5
Description
Audits of my node should be reasonably fast. It currently has about 7000 payments on it. I see that when doing audits each of the payments result in a network call to decode the payment request. This could just as well be done in-memory, which would speed things up by quite a lot.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the audit path that decodes each payment request and identify where the network call is made. Confirm the in-memory decoding path and verify that audits still produce the same results without one network request per payment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100