lightninglabs / lightninglabs/faraday

Fiat Price Lookup - Coindesk API Changed

Open
#222 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
130
Forks
35
Avg merge
7h 54m
Merged PRs (30d)
5

Description

**Expected behavior**
--enable_fiat should output fiat amounts for each transaction after requesting historical price data from Coindesk

**Actual behavior**
2025-08-06 14:14:58.030 [ERR] FIAT: http get attempt: 0 failed: Get "https://api.coindesk.com/v1/bpi/historical/close.json?start=2025-07-29&end=2025-08-06": dial tcp: lookup api.coindesk.com on {dns server}: no such host

**Fix**
Update Coindesk API calls and point them to their new endpoint address https://data-api.coindesk.com
More info: https://developers.coindesk.com/documentation/data-api/introduction

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Coindesk historical-price request used by --enable_fiat and review the documented replacement endpoint at data-api.coindesk.com. The work is done when historical price requests succeed and --enable_fiat outputs fiat amounts for each transaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.