lightninglabs / lightninglabs/faraday
Should provide flag for using system TLS certs
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 130
- Forks
- 35
- Avg merge
- 7h 54m
- Merged PRs (30d)
- 5
Description
I have a LND node running behind TLS that's accepted by my system without having to specify a custom TLS cert path. This is currently very hard to use with Faraday out of the box. I got it to work by commenting out line 77 in `faraday.go`, and adding `SystemCert: true` to the `lndclient.LndServicesConfig` struct.
https://github.com/lightninglabs/faraday/blob/bb8671250f32745f9b370b86c9e9b126ca9e11ce/faraday.go#L77
It would be a good idea to expose this functionality through CLI flags.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with faraday.go at line 77 and inspect how lndclient.LndServicesConfig is constructed. Trace the existing custom TLS certificate configuration to the CLI entry point, then expose the SystemCert setting as a flag. Done means a node trusted by the system can connect without a custom TLS certificate path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100