lightninglabs / lightninglabs/chantools

Fix MinHTLC/MaxHTLC calculation in dropchannelgraph

Open
#46 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
239
Forks
46
Avg merge
1d 6h
Merged PRs (30d)
6

Description

The min/max HTLC settings on the freshly inserted edge policies after dropping the graph seem to be incorrect.

```
[lncli] rpc error: code = Unknown desc = generated invalid channel update sig: max_htlc(20000000000 mSAT) for channel update greater than capacity(1000000000 mSAT)
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the dropchannelgraph entry point and tracing how min/max HTLC values are calculated for freshly inserted edge policies. Reproduce the reported invalid channel update signature and verify that the resulting max_htlc does not exceed the channel capacity while the min/max settings remain valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.