lightninglabs / lightninglabs/L402
accomodate grpc v1.40.0 402 response code / error formatting changes
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 91
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
Dysfunction
As mentioned in https://github.com/lightninglabs/pool/pull/451 and other PRs google.golang.org/grpc v1.40.0 has changed their 402 response code by improving the parsing from the HTTP/2 stack (see https://github.com/grpc/grpc-go/pull/4474). Consequently when the response code is output by gRPC, it's format has changed.
Necessary Remediation
This output change necessitates an update to L402 to continue to be compatible. Short term mitigation is to downgrade to grpc v1.39.0
Scope
Scope of engineering work to fix should be easy
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating L402's handling of gRPC HTTP 402 responses and compare its expected error formatting with the grpc-go v1.40.0 change described in the issue and linked PRs. Update the compatibility handling so the newer response format is accepted, then verify the existing error-handling coverage or add focused coverage if the repository provides a test location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- grpc
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100