lightly-ai / lightly-ai/lightly

Be more clear about the models and mention the difference in implementation compared to the papers

Open
#93 4 comments 1 reaction 1 assignee View on GitHub

@pranavsinghps1 is already working on this.

Since May 16, 2021.

documentation
Dominant language
Python
Stars
3.8k
Forks
367
Avg merge
3d 22h
Merged PRs (30d)
5

Description

For SimCLR and MoCo there are two versions. Our implementations are more close to v2 of both from what I've seen. But I'm not sure we use all the changes from the papers. I think it makes sense to clarify which model lightly is using and if there is a difference to the paper we should mention this. Maybe also mention how one could use SimCLRv1 or SimCLRv2 by changing some of the parameters?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.