liftedinit / liftedinit/many-rs

Semantic iterator for all objects that we store in merk needed

Open
#356 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
6
Forks
11
PR merge metrics
No merged PRs in 30d

Description

This may already be compulsory to finish the hash migration for merk keys, but it does not appear that there is a single iterator that iterates over all of the objects that we currently store in merk. The existing iterators (e.g. events, symbols, multisig) appear to have been constructed in bespoke fashion as they've been needed. It would be clearer for developers working on future migrations, where the items to be modified may be different from data modified in past migrations, to work with a more general iterator and filter from it, versus constructing individual iterators for each item type.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing bespoke merk iterators for events, symbols, and multisig, then compare how each enumerates stored objects. Define the shared iterator and its filtering boundary from those implementations. Done means future migrations can iterate over all stored objects and select the relevant items without adding another bespoke iterator.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.