liftedinit / liftedinit/many-rs

Problem adding `Context` context parameter to idstore and event endpoints

Open
#300 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
6
Forks
11
PR merge metrics
No merged PRs in 30d

Description

When attempting to add a context parameter, the compiler complained about the Context type not implementing Decode, when this has not happened for other ledger endpoints.

For example: Changing

fn get_from_recall_phrase(
        &self,
        args: idstore::GetFromRecallPhraseArgs,
    ) -> Result<idstore::GetReturns, ManyError>

to

fn get_from_recall_phrase(
        &self,
        args: idstore::GetFromRecallPhraseArgs,
        context: Context
    ) -> Result<idstore::GetReturns, ManyError>

reproduces the compiler error mentioned.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the get_from_recall_phrase entry point and the idstore and event endpoint definitions, then inspect how Context and Decode are handled for other ledger endpoints. Confirm the compiler error and compare the relevant endpoint signatures; the work is done when the intended Context parameter compiles consistently for these endpoints.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.