sendAndGetReply return type incorrect
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.3k
- Forks
- 275
- PR merge metrics
- No merged PRs in 30d
Description
Mailing List thread:
Below is a bit of code out of LiftActor.scala and it looks to me like
the proper return type of sendAndGetReply should be Box[Any] rather
than Any.
/**
- Send a message to the Actor and wait for
- up to timeout milliseconds for
- the actor to process the message and reply.
- This method is the Java callable version of !?.
*/
def sendAndGetReply(timeout: Long, msg: Any): Any = this.!?(timeout, msg)
/**
- Send a message to the Actor and wait for
- up to timeout milliseconds for
- the actor to process the message and reply.
*/
def !?(timeout: Long, message: Any): Box[Any] =
this !! (message, timeout)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in LiftActor.scala at sendAndGetReply and compare its declared return type with !?, then inspect callers for compatibility. Done when the public declaration accurately reflects the returned value and the relevant project checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100