lift / lift/framework

Don't covert entities in certain cases

Open
#1,368 1 comment 0 reactions 1 assignee View on GitHub

@dpp is already working on this.

Since Nov 26, 2012.

Dominant language
Scala
Stars
1.3k
Forks
275
PR merge metrics
No merged PRs in 30d

Description

When the "don't convert entity" flag is passed to the Html5 writer... don't convert entities:

```
case er: EntityRef if convertAmp =>
HtmlEntities.entMap.get(er.entityName) match {
case Some(chr) if chr.toInt >= 128 => writer.append(chr)
case _ => {
val sb = new StringBuilder()
er.buildString(sb)
writer.append(sb)
}
}

case er: EntityRef =>
val sb = new StringBuilder()
er.buildString(sb)
writer.append(sb)
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.