lift / lift/framework

Unify LiftScreen field declaration API with type parameters

Open
#1,042 1 comment 0 reactions 1 assignee View on GitHub

@dpp is already working on this.

Since Mar 1, 2012.

P:Normal Wizard
Dominant language
Scala
Stars
1.3k
Forks
275
PR merge metrics
No merged PRs in 30d

Description

Some of field declaration methods have type parameters (like selectT, multiselectT ) and others don′t (like radio(...) ).
It would be great all methods have type parameters for consistency.
Also radio(...) is documented with “@param f a PairStringPromoter (a wrapper around a function) that converts T => display String” which is not used in the method declaration.

Discussion: https://groups.google.com/d/topic/liftweb/VbFjuuRPuv0/discussion

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.