lifeart / lifeart/ember-class-modifier
Overwrites existing class, not compatible with splattributes
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 9
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Reproduction
(local-class comes from ember-css-modules.)
<strong
class="foo"
local-class="bar"
{{class "baz"}}
></strong>
<em
{{class "baz"}}
...attributes
></em>
Expected
<strong
class="foo _bar_ew67wi baz"
></strong>
<em
class="baz whatever is passed from the parent template"
></em>
Actual
<strong
class="baz"
></strong>
<em
class="baz"
></em>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two template cases shown in the issue, including the local-class and ...attributes inputs, then inspect the class modifier's handling of existing class attributes. Done means preserving the existing class, adding the local and modifier classes, and retaining classes passed through ...attributes as shown in the expected output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100