life-itself / life-itself/web3

Investigate performance impact of Tooltips

Open
#172 0 comments 0 reactions 1 assignee View on GitHub

@olayway is already working on this.

Since Jun 7, 2022.

Tech
Dominant language
HTML
Stars
1.9k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

> This was only done for code-splitting for page performance as recommended in lighthouse...

I see... I've added the dynamic imports back for now but I have enabled back ssr rendering for `Anchor`'s, because I think we do want them to be visible on the first-page load. If we don't render them on the server-side this is how the page looks like for a short moment (or not so short, depending on the internet connection) before it's fully rendered on the client:

![image](https://user-images.githubusercontent.com/52197250/172366084-37e07ded-f4d4-4979-a762-e683d8f458b3.png)
![image](https://user-images.githubusercontent.com/52197250/172367153-1cd6ae5a-5a80-4ab2-98b6-453d69ac55f4.png)

I suspect the metrics improvement still had to do with the `Tooltip` attached to those `Anchors`. I'll create and issue for that and I'll investigate it.

_Originally posted by @olayway in https://github.com/life-itself/web3/issues/167#issuecomment-1148536829_

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.