lidofinance / lidofinance/validator-ejector

Suppressed initial-cycle failures can permanently skip the oldest configured exit-request blocks

Open
#198 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
16
Forks
19
Avg merge
1d 20h
Merged PRs (30d)
7

Description

Locations

Summary

The initial polling cycle reports success to the application even when its handler throws. Because the next attempt recomputes its lookback from a later finalized block, exit requests near the original lookback boundary can be omitted permanently.

Root cause

makeJobRunner.once catches every handler exception without rethrowing it, while makeApp.run awaits that call as a startup readiness gate and then unconditionally logs that initial events were loaded and schedules the next attempt.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with validator-ejector/src/lib/job/index.ts:32-39 and validator-ejector/src/app/service.ts:61-71. Trace how makeJobRunner.once handles the initial handler failure and how makeApp.run uses that result before scheduling the next attempt. Done means an initial-cycle failure cannot make exit requests near the original lookback boundary disappear permanently.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.