lidofinance / lidofinance/scripts
Remove duplication of vote items descriptions
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8
- Forks
- 3
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 8
Description
There are two vote item descriptions:
1:
reference="Initial DAI funding Pool Maintenance Labs Ltd. within Nov'22-Apr'23 budget",
which goes into Aragon Finance NewTransaction event
2:
vote_desc_items = [
"1) Send DAI 1,500,000 to Pool Maintenance Labs Ltd. 0x17F6b2C738a63a8D3A113a228cfd0b373244633D",
which goes to Votings bot notifier
And usually the first description is more about "why and what in broader sense" and the second in more about the specific on-chain actions.
Maybe we should use uniform description, just exclude info about the addresses and values from NewTransaction event
And the question is in what form the unified description should be.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the reference used in the Aragon Finance NewTransaction event and the vote_desc_items passed to the Votings bot notifier. Define the unified description format, including what information each consumer should omit or retain, and verify that both outputs use it consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100