lidofinance / lidofinance/scripts
Correct validators data in VEBO tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8
- Forks
- 3
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 8
Description
Here is an improved and corrected version of the text:
-
In the tests for the validator exit bus, the commonly used
getLastRequestedValidatorIndices()method does not handle cases where it returns-1. It is recommended to add anassert()to ensure that the returned value is not equal to-1. For instance, the check should be added in this example: test_veb_negative.py, Line 229. -
In some tests where a
LidoValidatoris created, an incorrect (validator_key,validator_id) pair is used. This can cause issues during test execution. An example of this can be found here: test_validator_exit_bus_happy_path.py, Line 86.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/acceptance/test_veb_negative.py around line 229 and tests/regression/test_validator_exit_bus_happy_path.py around line 86. Review uses of getLastRequestedValidatorIndices() and LidoValidator construction across the VEBO tests. Done means returned indices are checked against -1 and validator_key/validator_id pairs are corrected wherever they are inconsistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- blockchain, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100