lidofinance / lidofinance/diffyscan

Incorrect diffs count in the report table

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
142
Forks
20
Avg merge
1d 13h
Merged PRs (30d)
15

Description

The column "Diffs" shows either incorrect or misleading number of differences. E. g. for this run https://app.warp.dev/block/VfjdKiz6Ofrv87pJpFPVHG it is "8" although the difference in html-report is just a single space added.

The config used (config_samples/zksync_mainnet_config_L1.json at the moment):

{
    "contracts": {
        "0xFf7F4d05e3247374e86A3f7231A2Ed1CA63647F2": "OssifiableProxy",
        "0x06185d60eD72a91D1367Eb0733B9d20AE7336D3B": "L1Executor",
        "0x41527B2d03844dB6b0945f25702cB958b6d55989": "OssifiableProxy",
        "0x9a810469F4a451Ebb7ef53672142053b4971587c": "L1ERC20Bridge"
    },
    "explorer_hostname": "api.etherscan.io",
    "github_repo": {
        "url": "https://github.com/txfusion/lido-l2",
        "commit": "fa6a77e694a34dc6f03d57bb8c934941e554ac9d",
        "relative_root": "zksync"
    },
    "dependencies": {
        "@openzeppelin/contracts": {
            "url": "https://github.com/OpenZeppelin/openzeppelin-contracts",
            "commit": "d4fb3a89f9d0a39c7ee6f2601d33ffbf30085322",
            "relative_root": "contracts"
        },
        "@openzeppelin/contracts-upgradeable": {
            "url": "https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable",
            "commit": "f6febd79e2a3a17e26969dd0d450c6ebd64bf459",
            "relative_root": "contracts"
        },
        "@matterlabs/zksync-contracts/l1/contracts": {
            "url": "https://github.com/matter-labs/era-contracts",
            "commit": "3a4506522aaef81485d8abb96f5a6394bd2ba69e",
            "relative_root": "ethereum/contracts"
        }
    }
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report using config_samples/zksync_mainnet_config_L1.json and compare the table's “Diffs” value with the single-space change shown in the HTML report for the linked run. Trace how the report table calculates this count and verify that the displayed number reflects the actual differences; the issue does not name a source file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.