lichess-org / lichess-org/fishnet

stop=false query parameter is never used

Open
#274 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
934
Forks
115
Avg merge
2d 1h
Merged PRs (30d)
2

Description

The [protocol](https://github.com/lichess-org/fishnet/blob/master/doc/protocol.md) specifies a boolean query parameter `stop`, which is set to true if the client just want to send the analysis result without acquiring the next job, or false if the client would like to acquire the next job immediately.

However, I noticed that the client always sends the query parameter as stop=true, there is no flag or configuration option to change this behavior. Even if I change the code responsible for the request to send stop=false instead, the rest of the client code does not expect the 202 Accepted response from the server when sending an analysis.

Are there plans to use allow the client to set this query parameter to false? Seems like it would be a nice option for dedicated machines. Also, if I implement an alternative fishnet client, would it be safe to pass this query parameter as false?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with doc/protocol.md and the client request code described in the issue. Trace how analysis submissions handle the server's 202 Accepted response and where the stop query parameter is fixed to true. Done means the client can opt into stop=false safely, with the corresponding response flow handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
distributed-systems, networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.