AddressSanitzer et al. exit leaves terminal echo disabled.
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 84
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
When xmp is terminated by AddressSanitizer, MemorySanitizer, etc. encountering an error and exiting, terminal echo is still turned off until manually fixed with stty echo, tput reset, or similar. I don't know what the correct solution is for this, but I tried adding an atexit hook to call reset_tty and it didn't help. This has been mildly annoying when diagnosing issues like https://github.com/libxmp/libxmp/issues/319 with input files that cause a lot of ASan/MSan exits.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing reset_tty cleanup and the termination paths used when AddressSanitizer or MemorySanitizer exits. Reproduce the failure with an input that triggers a sanitizer exit and compare it with normal termination. Done means the terminal echo is restored automatically after the sanitizer-triggered exit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100