[PATCH] HTTP::Message->parse works with strings without empty line between headers and body [rt.cpan.org #119570]

Migrated from rt.cpan.org#119570 (status was 'new')

Requestors:

• cpan@bambra.net

Attachments:

• HTTP-Message.patch

From cpan@bambra.net on 2016-12-29 14:27:55:

Hello,

I was very surprised by the fact, that there is no difference for HTTP::Message->parse between strings "Header: value\nbody" and "Header: value\n\nbody". The first one seems to be invalid, but it is parsed the same way as the second. This can lead to the problems when we parse buggy application output, because module don't see these bug, but real webserver see it.

I suggest the patch for the library and it's test file. As you understand, it can broke applications that rely on old behaviour, that is very very old, so it is not safe. What do you think about it?

Start by reviewing the attached HTTP-Message.patch and locating the HTTP::Message->parse entry point and its existing parser tests. Compare inputs with and without the empty line between headers and body, then verify the intended distinction with regression coverage while considering the compatibility concern noted in the issue.