libwww-perl / libwww-perl/HTTP-Daemon

HTTP::Daemon::ClientConn::send_basic_header() always sends Server: and Date: headers [rt.cpan.org #16330]

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Perl
Stars
6
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Migrated from rt.cpan.org#16330 (status was 'new')

Requestors:

  • adam.rice@efi.com

From on 2005-12-07 02:09:26
:

HTTP::Daemon::ClientConn::send_basic_header() always
sends Server: and Date: headers, even if they already exist
in the HTTP::Response object. This is a problem because
send_response() always calls send_basic_header(). In my case,
the HTTP::Response object is an actual response from another
server, so naturally already contains those headers.

Fortunately, the excellent design of the class made it easy for
me to override send_basic_header() in a subclass, but it would
have been nice if I hadn't had to.

Irrelevant but apparently compulsory information:
libwww-perl-5.803 (from CPAN, not Debian package)
Perl 5.8.4 (Debian package version 5.8.4-8)
Linux 2.6.11 (Debian-based custom distro)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate HTTP::Daemon::ClientConn::send_basic_header() and inspect how send_response() uses it with an HTTP::Response object. Reproduce the case where Server and Date already exist, then verify that existing values are preserved while missing headers still receive the expected defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.