libwww-perl / libwww-perl/HTML-Parser
Edge case with trailing text unreported
Nobody has claimed this yet.
- Dominant language
- Perl
- Stars
- 7
- Forks
- 15
- Avg merge
- 12h 8m
- Merged PRs (30d)
- 2
Description
With HTML::Parser v3.76.
Consider the following chunk of data:
Hello world! <span class="highlight">Isn't this wonderful</span> really?
Creating an object, such as:
# using curry and assuming this runs within a module that acts as a simple wrapper, nothing fancy.
my $p = HTML::Parser->new(
api_version => 3,
start_h => [ $self->curry::add_start, 'self, tagname, attr, attrseq, text, column, line, offset, offset_end'],
end_h => [ $self->curry::add_end, 'self, tagname, attr, attrseq, text, column, line, offset, offset_end' ],
marked_sections => 1,
comment_h => [ $self->curry::add_comment, 'self, text, column, line, offset, offset_end'],
declaration_h => [ $self->curry::add_declaration, 'self, text, column, line, offset, offset_end'],
default_h => [ $self->curry::add_default, 'self, tagname, attr, attrseq, text, column, line, offset, offset_end'],
text_h => [ $self->curry::add_text, 'self, text, column, line, offset, offset_end'],
empty_element_tags => 1,
end_document_h => [ $self->curry::end_document, 'self, skipped_text'],
);
$p->parse( $html );
sub add_text
{
my $self = shift( @_ );
print( "got '", $_[1], "'\n" );
}
And this would yield:
got 'Hello world! '
got 'Isn't this wonderful'
However, ' really?' is not being reported.
One has to explicitly call $p->eof to have the trailing text reported.
If this is an intended feature, then it ought to be made clear in the documentation. However, I think one should not have to call eof to get that last trailing text.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the HTML::Parser v3.76 example and tracing how the parse call handles the trailing text compared with an explicit eof call. Determine whether the expected result is automatic reporting of trailing text or clarified documentation, then add coverage for the example and verify the chosen behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100