Downstream breakage due to #4694
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 27.2k
- Forks
- 3.9k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 17
Description
#4694 assumed that the default size of the buffers from the socketpair was 64k on linux, which at least, in my box is much larger: 212992, whereas after the change they're set to 131072 which is 128k (2x64k) as man (7) socket explains:
Sets or gets the maximum socket receive buffer in bytes. The kernel doubles this value (to allow space for bookkeeping overhead) when it is set using setsockopt(2), and this doubled value is returned by getsockopt(2).
This is causing failures in the node.js CI: https://ci.nodejs.org/job/node-test-commit-linux-containered/50277/nodes=ubuntu2204_sharedlibs_withoutssl_x64/testReport/junit/(root)/parallel/test_child_process_stdout_flush_exit/.
Should we revert this or just apply the changes to macOS? Whatever we decide we'll need to make a patch release afterwards.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading #4694 and the linked Node.js CI report for test_child_process_stdout_flush_exit. Compare the socketpair buffer behavior on Linux and macOS and determine whether the change should be reverted or limited to macOS. Done means the downstream failure is resolved and the required patch-release decision is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, node.js
- Domain
- ci-cd, networking, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100