libuv / libuv/libuv

provide uv_umask function

Open
#1,693 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request v2 windows
Dominant language
C
Stars
27.2k
Forks
3.9k
Avg merge
2d 16h
Merged PRs (30d)
17

Description

libuv is using the value of umask on Windows to alter the requested file permissions: https://github.com/libuv/libuv/blob/70d61b6c30db99721894885222b1bf7b1f70d0da/src/win/fs.c#L395
but it doesn't provide any way to either select which umask function to use (On Windows, this state is stored in the client program not the kernel, so a process may have multiple conflicting copies of this function loaded – e.g. approximately the same issue as https://github.com/libuv/libuv/pull/1323) or to change the value into the umask libc that libuv is linked against (e.g. how uv_replace_allocator works).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/win/fs.c at the referenced umask use around line 395, then compare the existing uv_replace_allocator API. Determine how a public uv_umask function should select or replace the libc umask state on Windows. Done means the requested API behavior is defined and implemented with coverage for the conflicting umask scenarios described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api, operating-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.