libretro / libretro/libretro-database

Arcade dats don't show that parent roms also need samples

Open
#381 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
877
Avg merge
3d 1h
Merged PRs (30d)
24

Description

I noticed the following with fbalpha dats but it applies to all arcade dats. Reference: https://github.com/libretro/fbalpha/issues/105#issuecomment-271067873
I noticed it with cheekyms, as the game has no clones and the fact that the game needs samples wasn't marked, as its sample isn't being mentioned in the header:

<game name="cheekyms">
		<description>Cheeky Mouse</description>
		<year>1980</year>
		<manufacturer>Universal</manufacturer>
		<rom name="cm03.c5" size="2048" crc="1ad0cb40"/>
		<rom name="cm04.c6" size="2048" crc="2238f607"/>
		<rom name="cm05.c7" size="2048" crc="4169eba8"/>
		<rom name="cm06.c8" size="2048" crc="7031660c"/>
		<rom name="cm01.c1" size="2048" crc="26f73bd7"/>
		<rom name="cm02.c2" size="2048" crc="885887c3"/>
		<rom name="cm07.n5" size="2048" crc="2738c88d"/>
		<rom name="cm08.n6" size="2048" crc="b3fbd4ac"/>
		<rom name="cm.m9" size="32" crc="db9c59a5"/>
		<rom name="cm.m8" size="32" crc="2386bc68"/>
		<rom name="cm.p3" size="32" crc="6ac41516"/>
		<sample name="squeek" />
		<sample name="hammer" />
		<sample name="sqeekdead" />
		<sample name="two" />
		<sample name="squeek2" />
	</game>

Samples of parent roms should be mentioned as well like this:
<game name="cheekyms" sampleof="cheekyms">

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the arcade DAT output for fbalpha, especially the cheekyms entry and its sample declarations. Update the generation or data path so parent ROM sample requirements are represented in the game header, then verify the resulting XML uses the requested sampleof attribute consistently across arcade DATs.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.