libretro / libretro/libretro-database

Final Fantasy VII (USA) (Disc 2) not being added to playlist

Open
#1,432 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
877
Avg merge
3d 1h
Merged PRs (30d)
24

Description

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

Opening as per https://docs.libretro.com/guides/roms-playlists-thumbnails/
"For a normal scan, the content must match existing databases from the libretro-database README. If those conditions are met but content is still not being added automatically to a playlist, consider submitting an issue report on github."

Final Fantasy VII (USA) (Disc 2) not being added to playlist, I presume the problem stems from Disc 1 2 and 3 having the same serial in redump:

http://redump.org/disc/66/
http://redump.org/disc/67/
http://redump.org/disc/68/

as opposed to other multi disc games such as Final Fantasy VIII:

http://redump.org/disc/69/
http://redump.org/disc/70/
http://redump.org/disc/71/
http://redump.org/disc/72/

Doing a manual scan results in lpl containing:
{
"path": "/storage/emulated/0/RetroArch/games/PS1 - Top 15/Final Fantasy VII (USA) (Disc 1).chd",
"label": "Final Fantasy VII (USA) (Disc 1)",
"core_path": "DETECT",
"core_name": "DETECT",
"crc32": "SCUS-94163-0|serial",
"db_name": "Sony - PlayStation.lpl"
},
{
"path": "/storage/emulated/0/RetroArch/games/PS1 - Top 15/Final Fantasy VII (USA) (Disc 2).chd",
"label": "Final Fantasy VII (USA) (Disc 2)",
"core_path": "DETECT",
"core_name": "DETECT",
"crc32": "00000000|crc",
"db_name": "Sony - PlayStation.lpl"
},
{
"path": "/storage/emulated/0/RetroArch/games/PS1 - Top 15/Final Fantasy VII (USA) (Disc 3).chd",
"label": "Final Fantasy VII (USA) (Disc 3)",
"core_path": "DETECT",
"core_name": "DETECT",
"crc32": "00000000|crc",
"db_name": "Sony - PlayStation.lpl"
},

Expected behavior

All discs are added to the playlist

Actual behavior

Only Disc 1 is added to the playlist

Steps to reproduce the bug

Import content -> Scan Directory (for content that matches the database)
Doing this on a directory which contains .chds, which within contain:

Bisect Results

N/A

Version/Commit

You can find this information under Information/System Information

N/A?

Environment information
  • OS: iOS and Android
  • Compiler: [In case you are running local builds]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the scan with the three Final Fantasy VII CHDs and inspect the Sony - PlayStation.lpl entry and matching database records. Done means a normal directory scan adds Disc 1, Disc 2, and Disc 3 to the playlist, rather than only Disc 1.

Written by the indexing model from the issue text.

Assessment

Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.