libretro / libretro/libretro-database
No match for digital nes games
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.4k
- Forks
- 877
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 24
Description
For example, from below is not recognized by retroarch, even if it has an entry on no-intro.
https://mhughson.itch.io/from-below
As pointed out in the comments, the original file has a given nes header, while no-intro replaced it with a nes 2.0 header before hashing, as it is done for all nes roms.
As no-intro also provides the hashes for the roms without header, it might make more sense that retroarch calculates the hash for nes files without the header if it does not found any match, ie ignore the first 16 bytes
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the mismatch with the linked From Below ROM and inspect the repository's content matching and hash-calculation entry points. Compare the full-file and headerless hashes against the no-intro entries; done means the NES content is recognized when its normal hash has no match, without breaking existing matches.
Written by the indexing model from the issue text.
Assessment
- Domain
- database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100