libretro / libretro/libretro-database

Not recognizing compressed German versions of Day of the Tentacle and Simon the Sorcerer

Open
#1,351 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
877
Avg merge
3d 1h
Merged PRs (30d)
24

Description

The scanner fails to recognize the German versions of Day of the Tentacle (CD) and Simon the Sorcerer (DOS/CD) if the audio files have been compressed with the ScummVM tools. This is happening because the database only looks for the original audio file:

rom ( name "MONSTER.SOU" size 238267139 crc ba6467a2 md5 8ea07a3e13af00f0a6e594820df1a9af sha1 8ea8934f1ef9e212e26fbd72463c9d0c42af8ee7 )

For other languages, the TENTACLE.000 is being checked, which should make the scanner work for non-German versions with compressed audio files.

Maybe the TENTACLE.000 file could be used to identify the German CD version of DotT? I still have the original disc so I could create a PR for that.

The situation is similar with Simon the Sorcerer which uses the file SIMON.WAV for identifying the German CD version while SIMON.GME is used to identify the English CD version. With this one, I also wonder if the German version could be identified by the SIMON.GME file, which has a different hash than the English version. I could also share this via a merge request.

Let me know what you think.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the German database entries that use MONSTER.SOU and SIMON.WAV with the alternative TENTACLE.000 and SIMON.GME files mentioned in the issue. Verify the hashes for the German CD versions and update the relevant entries so compressed audio is recognized; done means both German versions scan successfully with compressed audio.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.