libretro / libretro/libretro-database

Unwanted tags in some GBA game titles

Open
#1,337 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.4k
Forks
877
Avg merge
3d 1h
Merged PRs (30d)
24

Description

Hello.

For some reason, a recent update has added x### tags to some Game Boy Advance games in the playlist, for example:

x109 - Super Mario Advance 4 - Super Mario Bros. 3 (USA) (Rev 1) (Virtual Console)

which is the one I noticed. Checking the dat file it seems that the initial No-Intro number is filtered for number tags only (no x), examples:

Fixed:

    name "Super Mario Advance 4 - Super Mario 3 + Mario Brothers (Japan)"
    rom ( name "1076 - Super Mario Advance 4 - Super Mario 3 + Mario Brothers (Japan).gba" size 4194304 crc F3C87306 md5 E559E292AA9D44287B052342D6469967 sha1 19F7928BC4FFD733D71884DAE9AD9B7F4007D38D serial "AX4J" )

Not Fixed:

    name "x250 - Super Mario Advance 4 - Super Mario 3 + Mario Brothers (Japan) (Rev 2) (Virtual Console)"
    rom ( name "x250 - Super Mario Advance 4 - Super Mario 3 + Mario Brothers (Japan) (Rev 2) (Virtual Console).gba" size 8388608 crc 4AEE9C77 md5 ED52707B19848C480866A86F28268273 sha1 72CCC0ECCE6CE08EADCE1B3DA4873CDD91851496 serial "AX4J" )

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the affected playlist titles with the corresponding dat entries shown in the report, then trace the title-cleaning or No-Intro number-tag handling entry point. Verify that the x### examples no longer appear while ordinary numeric tags remain unchanged, and add or update a regression test if the repository has one.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.