libretro / libretro/libretro-common

provide a way for cores with need_fullpath==false to determine content filename

Open
#82 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
180
Forks
98
Avg merge
7h 16m
Merged PRs (30d)
1

Description

Many cores create save and configuration files which are named based on the filename of the content they are executing.

When a core sets need_fullpath==false, there is no means specified in libretro.h for the core to determine the filename so there is no way to name the save files. @fr500 provides an example of this issue from beetle-gba here: https://github.com/libretro/beetle-gba-libretro/pull/33#issuecomment-406910261

I'm creating this issue because it seems separate from the PR I submitted to clarify the existing behavior.

Two possible ways I can think of to provide the name of the content to the core are:

  • update the API so that if need_fullpath == false then retro_game_info::path will return the filename of the content (not the full path)
  • create a new callback which returns the name of the content

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with libretro.h and the definitions of retro_game_info, need_fullpath, and existing callbacks. Compare the two API options described in the issue with the linked PR clarifying existing behavior; done means cores can determine the content filename when need_fullpath is false through an agreed API behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.