libretro / libretro/libretro-common
cpu_features_get_perf_counter seems incorrect for macOS
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 180
- Forks
- 98
- Avg merge
- 7h 16m
- Merged PRs (30d)
- 1
Description
Looks like there is no case of macOS here:
https://github.com/libretro/libretro-common/blob/668749ae38a9e85744d1c15a652a1e8db8ab9e82/features/features_cpu.c#L155-L214
x86 and arm64 will use arch-specific cases, but for powerpc there is nothing, since macOS is excluded here: https://github.com/libretro/libretro-common/blob/668749ae38a9e85744d1c15a652a1e8db8ab9e82/features/features_cpu.c#L179-L180
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in features/features_cpu.c, especially lines 155-214 and the macOS exclusion at lines 179-180. Compare how the x86 and arm64 architecture-specific cases handle cpu_features_get_perf_counter, then determine the appropriate macOS PowerPC behavior. Done means macOS is handled correctly rather than falling through without a case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100