libretro / libretro/libretro-common

`libchdr/chdconfig.h` not present

Open Beginner friendly
#220 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
180
Forks
98
Avg merge
7h 16m
Merged PRs (30d)
1

Description

Hi, first of all, thanks for the hard work you do on Libretro!

In commit 8f1ee60, a change was introduced to include/libchdr/cdrom.h and include/libchdr/chd.h to import the header libchdr/chdconfig.h, but libchdr/chdconfig.h is not present in the repository. Commenting out that include is good enough to compile as it seems that header is unused.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the referenced commit and the includes in include/libchdr/cdrom.h and include/libchdr/chd.h. Reproduce the compilation issue and determine how the absent libchdr/chdconfig.h reference should be handled. Done means the repository no longer requires a missing header and the affected code compiles.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.