libretro / libretro/libretro-common
VFS Broken since CDRom change?
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 180
- Forks
- 98
- Avg merge
- 7h 16m
- Merged PRs (30d)
- 1
Description
vendor/libretro-common/vfs/vfs_implementation_cdrom.c: In function ‘retro_vfs_file_seek_cdrom’:
vendor/libretro-common/vfs/vfs_implementation_cdrom.c:49:19: error: ‘libretro_vfs_implementation_file {aka struct libretro_vfs_implementation_file}’ has no member named ‘cdrom’
stream->cdrom.byte_pos = offset;
^~
compilation terminated due to -Wfatal-errors.
Makefile:25: recipe for target 'vendor/libretro-common/vfs/vfs_implementation_cdrom.o' failed
make: *** [vendor/libretro-common/vfs/vfs_implementation_cdrom.o] Error 1
https://github.com/libretro/libretro-common/blob/master/vfs/vfs_implementation_cdrom.c#L49
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vendor/libretro-common/vfs/vfs_implementation_cdrom.c, especially retro_vfs_file_seek_cdrom at line 49, and inspect the libretro_vfs_implementation_file definition. Run make to reproduce the compilation failure and confirm that the CD-ROM VFS object builds successfully when the issue is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100