libretro / libretro/libretro-common
reserved identifier violation
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 180
- Forks
- 98
- Avg merge
- 7h 16m
- Merged PRs (30d)
- 1
Description
I would like to point out that identifiers like “__LIBRETRO_SDK_FILE_PATH_H” and “__RARCH_MISCELLANEOUS_H” do eventually not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the include guards at line 23 of include/file/file_path.h and include/retro_miscellaneous.h, then check whether the same naming issue appears in nearby headers. Update the reserved identifiers to names that follow the C standard's naming rules and verify the affected headers still compile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100