add SET_ROTATION support to SDL video driver
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
per @dankcushions findings, presently the SDL video driver does not implement rotation: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/sdl_gfx.c#L563
It might be helpful to point out that the SDL2 driver does implement SET_ROTATION: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/sdl2_gfx.c#L598
A few platforms only support SDL video, and this renders some games/cores unusable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in gfx/drivers/sdl_gfx.c around line 563 and compare the existing SET_ROTATION handling in gfx/drivers/sdl2_gfx.c around line 598. The work is done when the SDL video driver supports SET_ROTATION consistently with the SDL2 driver, allowing rotation-dependent games and cores to run on SDL-only platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100