[Feature Request] filter out (always) the menu toggle controller combo from overlays
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
As in the title, disable hotkey controller combo if they come from a overlay, since all RetroArch default overlays have the open menu button anyway and it is easy to get a combo to flicker the menu for a fraction of a second and return to the game if you dont release it just as fast - maybe another bug.
Plus pressing by accident is not unusual, so if there already is a dedicated button, no reason not to ignore it.
If you can query the current overlay instead of "always" filter (to accommodate user overlays without the button) checking if the hotkey combo came from the overlay and the overlay has a dedicated open menu button is a less strict condition that accommodates overlays without the open menu button.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing RetroArch's overlay input handling and the path that processes the menu-toggle controller hotkey. Determine whether the current overlay and its dedicated menu button are available at that point, then verify the chosen filtering behavior with overlay input scenarios, including overlays without a dedicated menu button.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100